Issue 397002: Avoid gmock warning "Uninteresting mock function call"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 397002: Avoid gmock warning "Uninteresting mock function call"

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by Michael Krebs

Modified:
11 years, 6 months ago

Reviewers:
Ted Mielczarek, vapier

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Avoid gmock warning "Uninteresting mock function call"

The call to MockSymbolSupplier::FreeSymbolData() was causing the following
gmock warning during unittests:
    GMOCK WARNING:
    Uninteresting mock function call - returning directly.
        Function call: FreeSymbolData(0x57600fd4)
This change fixes it by just allowing it to be called whenever.

BUG=chromium-os:20133
TEST=Ran unittests

Patch Set 1 #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/processor/minidump_processor_unittest.cc	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	src/processor/stackwalker_amd64_unittest.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/processor/stackwalker_arm_unittest.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/processor/stackwalker_x86_unittest.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ted Mielczarek

On 2012/09/14 12:20:11, Ted Mielczarek wrote: > LGTM Do you need me to land this ...

12 years, 2 months ago #2

vapier

On 2012/09/14 12:23:00, Ted Mielczarek wrote: > On 2012/09/14 12:20:11, Ted Mielczarek wrote: > > ...

11 years, 6 months ago #3

Ted Mielczarek

11 years, 6 months ago #4

Pushed in r1183:
http://code.google.com/p/google-breakpad/source/detail?r=1183

Expand All Messages | Collapse All Messages