Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 391002: Fix uploader so that it send the guid to the server. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by qsr
Modified:
12 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

 Fix uploader so that it send the guid to the server.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/sender/uploader.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
qsr
I might miss something here, but I have the impression that the guid is never ...
12 years, 4 months ago #1
Mark Mentovai
I can’t even follow this file easily anymore. Is the test “I saw a dump ...
12 years, 4 months ago #2
qsr
On 2012/06/01 21:52:00, Mark Mentovai wrote: > I can’t even follow this file easily anymore. ...
12 years, 4 months ago #3
Mark Mentovai
12 years, 4 months ago #4
LGTM. I guess this does the right thing given how -populateServerDictionary:
appears to work. I don’t know how this worked before. It seems to follow the
same code for over a year.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted