I might miss something here, but I have the impression that the guid is never
send to the server, as the method that add upload parameter check if the
parameter is in the server association map. (And I indeed to not see different
client id for my crashes, but what is weird is that it was working a month ago,
and I can't figure out why).
I can’t even follow this file easily anymore.
Is the test “I saw a dump uploaded before and it didn’t have this parameter, and
now with this change, it does?”
On 2012/06/01 21:52:00, Mark Mentovai wrote:
> I can’t even follow this file easily anymore.
:(
> Is the test “I saw a dump uploaded before and it didn’t have this parameter,
and
> now with this change, it does?”
Something like that. But I'd love for you to explain me how is it that with the
current code, I ever had some information about the client... I might be missing
something completely obvious.
LGTM. I guess this does the right thing given how -populateServerDictionary:
appears to work. I don’t know how this worked before. It seems to follow the
same code for over a year.
Issue 391002: Fix uploader so that it send the guid to the server.
(Closed)
Created 12 years, 5 months ago by qsr
Modified 12 years, 5 months ago
Reviewers: Mark Mentovai
Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Comments: 0