Issue 390003: Initialize a CustomClientInfo variable. (Coverity)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 390003: Initialize a CustomClientInfo variable. (Coverity) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by Lei Zhang (chromium)

Modified:
12 years, 5 months ago

Reviewers:
Cris Neckar, cpu1

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Initialize a CustomClientInfo variable. (Coverity)
Committed: https://code.google.com/p/google-breakpad/source/detail?r=967

Patch Set 1 #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/windows/crash_generation/crash_generation_client.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Lei Zhang (chromium)

Coverity complains about this variable being uninitialized after r961. I think this should fix it, ...

12 years, 5 months ago #1

Yeah that fixes it. That field is unused on the other side for this message
anyway so this shouldn't have caused problems but this makes it clean. thanks.

LGTM

Expand All Messages | Collapse All Messages