Issue 389002: Unprotect the allocator before trying to create a minidump from a signal.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 389002: Unprotect the allocator before trying to create a minidump from a signal. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by qsr

Modified:
12 years, 5 months ago

Reviewers:
stuart.morgan

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

 Unprotect the allocator before trying to create a minidump from a signal.

 It is impossible to write a minidump with memory protected. This means that
before this change, no minidump were created when a signal was caught, instead
the application froze.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=964

Patch Set 2 : #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/mac/handler/exception_handler.cc	View	1	6 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

stuart.morgan

LGTM with spacing fixes. https://breakpad.appspot.com/389002/diff/1/src/client/mac/handler/exception_handler.cc File src/client/mac/handler/exception_handler.cc (right): https://breakpad.appspot.com/389002/diff/1/src/client/mac/handler/exception_handler.cc#newcode586 src/client/mac/handler/exception_handler.cc:586: if(gBreakpadAllocator) Missing space between if ...

12 years, 5 months ago #2

qsr

12 years, 5 months ago #3

https://breakpad.appspot.com/389002/diff/1/src/client/mac/handler/exception_h...
File src/client/mac/handler/exception_handler.cc (right):

https://breakpad.appspot.com/389002/diff/1/src/client/mac/handler/exception_h...
src/client/mac/handler/exception_handler.cc:586: if(gBreakpadAllocator)
On 2012/05/14 11:30:20, stuart.morgan wrote:
> Missing space between if and ( here and below.

Done.

Expand All Messages | Collapse All Messages