Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 388002: sym_upload: Show failure if symbol server gives redirect response (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Michael Krebs
Modified:
12 years, 6 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

sym_upload: Show failure if symbol server gives redirect response

Add a "response_code" parameter to Linux's HTTPUpload::SendRequest() that,
if non-NULL, will be set to the response code of the HTTP request.  Using
that, sym_upload will print a failure message on Linux if the response code
is not 200.  This is in line with the change made by
http://breakpad.appspot.com/77001/ for the Mac version.

BUG=google-breakpad:480, chromium-os:30032
TEST=Ran "sym_upload powertop.sym http://test.webdav.org/redir-tmp/"
     Ran "sym_upload powertop.sym http://clients2.google.com/cr/staging_symbol"
Committed: https://code.google.com/p/google-breakpad/source/detail?r=968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/linux/http_upload.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/common/linux/http_upload.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/tools/linux/symupload/minidump_upload.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/tools/linux/symupload/sym_upload.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 2
Michael Krebs
12 years, 6 months ago #1
Ted Mielczarek
12 years, 6 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted