Issue 384001: wires up the crash client side so that the deferred upload callback can be used.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 384001: wires up the crash client side so that the deferred upload callback can be used. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Cris Neckar

Modified:
12 years, 5 months ago

Reviewers:
cpu

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

wires up the crash client side so that the deferred upload callback can be used.

TEST=N/A 
Committed: https://code.google.com/p/google-breakpad/source/detail?r=961

Patch Set 1 #

Total comments: 1

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/windows/crash_generation/crash_generation_client.cc	View	1 chunk	+17 lines, -0 lines	1 comment	Download
M	src/client/windows/crash_generation/crash_generation_client.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/client/windows/crash_generation/crash_generation_server.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/client/windows/handler/exception_handler.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/client/windows/handler/exception_handler.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

cpu

12 years, 5 months ago #2

lgtm

sorry for the delay.

http://breakpad.appspot.com/384001/diff/1/src/client/windows/crash_generation...
File src/client/windows/crash_generation/crash_generation_client.cc (right):

http://breakpad.appspot.com/384001/diff/1/src/client/windows/crash_generation...
src/client/windows/crash_generation/crash_generation_client.cc:178:
(MINIDUMP_TYPE)NULL, NULL, NULL, NULL,
this (MINIDUMP_TYPE)0 cast is not needed right?

Expand All Messages | Collapse All Messages