Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(97)

Issue 377003: vectors are cleared with "clear()", not with "empty()".

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by thakis
Modified:
12 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/
Visibility:
Public.

Description

vectors are cleared with "clear()", not with "empty()".

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M common/string_conversion.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
thakis
Has little actual impact, but it's still a bug.
12 years, 7 months ago #1
Lei Zhang (chromium)
LGTM, bleh.
12 years, 7 months ago #2
thakis
Thanks! Can you land? I'm not a breakpad committer.
12 years, 7 months ago #3
Mark Mentovai
12 years, 7 months ago #4
LGTM too. Looks like thestig landed this at r949.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted