Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(270)

Issue 3704002: Stringify minidump stream_type constants in minidump_dump output (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by Ted Mielczarek
Modified:
10 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

I frequently find myself looking at minidump_dump output and deciphering
constants. This helps for the stream directory, at least. You can see the new
output in the testdata diff. I'm not wild about having a hardcoded list in a
function like this, but there's no sane way to do this in C++ and I didn't want
to munge the header into a bunch of macrology.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/minidump.cc View 2 chunks +71 lines, -2 lines 1 comment Download
M src/processor/testdata/minidump2.dump.out View 1 chunk +17 lines, -17 lines 0 comments Download

Messages

Total messages: 2
Ted Mielczarek
I forgot to send mail, as usual.
10 years, 4 months ago #1
Mark Mentovai
10 years, 4 months ago #2
I would have been OK with a stringify macro too, by the way.

LGTM

https://breakpad.appspot.com/3704002/diff/1/src/processor/minidump.cc
File src/processor/minidump.cc (right):

https://breakpad.appspot.com/3704002/diff/1/src/processor/minidump.cc#newcode...
src/processor/minidump.cc:4775: printf("  stream_type        = %d (%s)\n",  
directory_entry->stream_type,
I think we should use 0x%x here like we do when we dump the stream map.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted