Add missing MD_MISCINFO_FLAGS1_BUILDSTRING

Add missing MD_MISCINFO_FLAGS1_BUILDSTRING. Revise documentation to clarify
that it is not enough to check the size of an MDRawMiscInfo stream to verify
member validity, the flags1 field needs to be consulted as well. Update
minidump_dump to correctly consider the validity of all fields in this
structure.

R=ivanpe@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1336

[Mark Mentovai]

MISC_INFO_3 and MISC_INFO_4 were added in r1204,
https://breakpad.appspot.com/617002. The validity flag,
MD_MISCINFO_FLAGS1_BUILDSTRING, was missing.

This also prints the complete MDTimeZoneInformation fields and fixes a bug where
the wrong validity flag was consulted for one field when printing
MDRawBreakpadInfo.

[Mark Mentovai]

Ping?

[ivanpe]

LGTM.

Sorry for the delay.  I was at a 3 days class last week and I couldn't get to
this yesterday.

https://breakpad.appspot.com/3694002/diff/1/src/processor/minidump.cc
File src/processor/minidump.cc (right):

https://breakpad.appspot.com/3694002/diff/1/src/processor/minidump.cc#newcode351
src/processor/minidump.cc:351: static void PrintValueOrInvalid(bool valid, bool
hexadecimal, uint32_t value) {
Nit: It may be more readable (especially at the call location) to use an
enumeration instead of bool here for hexadecimal.

[Mark Mentovai]

Good idea on the enum argument, thanks.

I also added time_t decoding for the process_create_time field. How does this
look?

[ivanpe]

On 2014/06/03 17:57:13, Mark Mentovai wrote:
> Good idea on the enum argument, thanks.
> 
> I also added time_t decoding for the process_create_time field. How does this
> look?

LGTM

[Mark Mentovai]

Committed patchset #2 manually as r1336 (presubmit successful).