Issue 368001: Fix class/struct mismatches in forward declarations.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 368001: Fix class/struct mismatches in forward declarations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Ben Chan

Modified:
12 years, 6 months ago

Reviewers:
Mark Mentovai, Lei Zhang (chromium)

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix class/struct mismatches in forward declarations.

This patch fixes some compiler warnings when compiling with clang.

BUG=none
TEST=Compile with clang and run unit tests.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=937

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/google_breakpad/processor/minidump_processor.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/google_breakpad/processor/source_line_resolver_interface.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/google_breakpad/processor/stack_frame_cpu.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/google_breakpad/processor/stackwalker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/google_breakpad/processor/symbol_supplier.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages