Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 366001: Fix GetMainModule() to properly get first module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Michael Krebs
Modified:
12 years, 7 months ago
Reviewers:
Mark Mentovai, Ben Chan
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix GetMainModule() to properly get first module

Change MinidumpModuleList::GetMainModule() to use GetModuleAtIndex() instead
of GetModuleAtSequence() because the former gets the first module that was
in the minidump file, while the latter actually gets the first module when
sorted by address.  While this is pretty much the same thing at the moment,
I have another change in the works that can sometimes affect the module
order in the file.

BUG=chromium-os:25355
TEST=Ran Breakpad tests
Committed: https://code.google.com/p/google-breakpad/source/detail?r=941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/minidump.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Michael Krebs
This is the upstream CL for https://gerrit.chromium.org/gerrit/18909
12 years, 8 months ago #1
Mark Mentovai
12 years, 8 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted