Issue 365001: Unregister waits when a client shuts down so that no further callback events can fire for that clie…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 365001: Unregister waits when a client shuts down so that no further callback events can fire for that clie… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by Cris Neckar

Modified:
12 years, 1 month ago

Reviewers:
munjal, cpu1, doshimun

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Unregister waits when a client shuts down so that no further callback events can
fire for that client.

BUG=117890
TEST=N/A
Committed: https://code.google.com/p/google-breakpad/source/detail?r=936

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/windows/crash_generation/crash_generation_server.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Cris Neckar

12 years, 1 month ago #3

On 2012/03/21 20:28:55, doshimun wrote:
> LGTM

Munjal would you mind landing this for me? I think my commit access for breakpad
is broken. It is listed as chromium.cdn@gmail which must have broken during the
chromium.org changes.

Expand All Messages | Collapse All Messages