Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(306)

Issue 362001: Enable CIE version 3 .eh_frame sections

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by mrmiller
Modified:
12 years, 1 month ago
Reviewers:
jimb, Ted Mielczarek, jimb
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/
Visibility:
Public.

Description

I've run into at least one library that has CIE version 3 .eh_frames.  Before,
Breakpad would simply ignore any entries within the .eh_frame section if it
wasn't version 1:
/usr/lib/libSystem.B.dylib, architecture : CFI frame description entry
at offset 0x148b8 in '__eh_frame': CIE specifies unrecognized version:
3
According to http://www.airs.com/blog/archives/460, the .eh_frame sections only
difference between versions 1 and 3 is the same change that we already account
for in .debug_frame sections: the return address register is LEB128 in version 3
instead of a single byte in version 1.

This patch simply allows reading of version 3 .eh_frame sections.

Patch Set 1 : Sorry, I truncated some context lines at the end of the patch file. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
common/dwarf/dwarf2reader.cc View 1 chunk +4 lines, -12 lines 0 comments Download

Messages

Total messages: 10
mrmiller
12 years, 2 months ago #1
mrmiller
Sorry, I truncated some context lines at the end of the patch file.
12 years, 2 months ago #2
jimb
Looks good to me!
12 years, 2 months ago #3
jimb
On 2012/03/15 23:41:02, jimb wrote: > Looks good to me! I can land this for ...
12 years, 2 months ago #4
jimb
On 2012/03/15 23:41:37, jimb wrote: > On 2012/03/15 23:41:02, jimb wrote: > > Looks good ...
12 years, 2 months ago #5
mrmiller
On 2012/03/15 23:42:20, jimb wrote: > On 2012/03/15 23:41:37, jimb wrote: > > On 2012/03/15 ...
12 years, 2 months ago #6
jimb_red-bean.com
Breakpad appears to be horked at the moment. I'll be on a business trip next ...
12 years, 2 months ago #7
mrmiller
Do we want to pick this back up? On 2012/03/16 01:54:11, jimb_red-bean.com wrote: > Breakpad ...
12 years, 1 month ago #8
jimb
On 2012/04/03 14:22:22, michaelrmmiller wrote: > Do we want to pick this back up? Yes ...
12 years, 1 month ago #9
jimb
12 years, 1 month ago #10
Committed as revision 947.

Michael, now you need to mark the issue closed in Rietveld (click on "Edit
Issue").
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted