Add SIGABRT handler for mac and iOS.

Add SIGABRT handler for mac and iOS.

 SIGABRT were not handled while in process. This change add a signal handler to
handle this.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=933

[qsr]

Just for info: for this first version, I am not parsing the context that the
signal is getting me, mainly because this is quite a lot of work and that stack
walking will get us most of what we need already.

[Mark Mentovai]

LGTM

However, I don’t think we should use this for the Mac until the stackwalking is
fixed, mostly because of the way things will be bucketed on the crash server.

https://breakpad.appspot.com/360001/diff/1/src/client/mac/handler/exception_h...
File src/client/mac/handler/exception_handler.cc (right):

https://breakpad.appspot.com/360001/diff/1/src/client/mac/handler/exception_h...
src/client/mac/handler/exception_handler.cc:318: report_current_thread ? NULL :
mach_thread_self());
Indentation.

https://breakpad.appspot.com/360001/diff/1/src/client/mac/handler/exception_h...
src/client/mac/handler/exception_handler.cc:589: // If an handler is already
installed, something is really wrong.
an handler -> a handler

[qsr]

PTAL as I disabled installing the handler for mac for now. Will try to work on
the context, but might not be just now.

http://breakpad.appspot.com/360001/diff/1/src/client/mac/handler/exception_ha...
File src/client/mac/handler/exception_handler.cc (right):

http://breakpad.appspot.com/360001/diff/1/src/client/mac/handler/exception_ha...
src/client/mac/handler/exception_handler.cc:318: report_current_thread ? NULL :
mach_thread_self());
On 2012/03/09 17:39:06, Mark Mentovai wrote:
> Indentation.

Done.

http://breakpad.appspot.com/360001/diff/1/src/client/mac/handler/exception_ha...
src/client/mac/handler/exception_handler.cc:589: // If an handler is already
installed, something is really wrong.
On 2012/03/09 17:39:06, Mark Mentovai wrote:
> an handler -> a handler

Done.

[Mark Mentovai]

LGTM

[ted_mielczarek.org]

On Fri, Mar 9, 2012 at 1:09 PM,  <qsr@chromium.org> wrote:
> PTAL as I disabled installing the handler for mac for now. Will try to
> work on the context, but might not be just now.

This would be cool to get working correctly on mac, since right now
there's no way to externally trigger Breakpad (in a hung application,
for example).

-Ted

[qsr1]

 It is my plan to have that working, especially because I just learned that
aggregation will only look at the first few frames and will be very wrong.

 It is not hard to do, but this is just some tiring code to write to
transform a u_context to the right format to pass to the minidump writer.

 Some of the work is already done on linux, I'll need to refactor this is
some common location.

On Fri, Mar 9, 2012 at 11:15 AM, Ted Mielczarek <ted@mielczarek.org> wrote:

> On Fri, Mar 9, 2012 at 1:09 PM,  <qsr@chromium.org> wrote:
> > PTAL as I disabled installing the handler for mac for now. Will try to
> > work on the context, but might not be just now.
>
> This would be cool to get working correctly on mac, since right now
> there's no way to externally trigger Breakpad (in a hung application,
> for example).
>
> -Ted
>
> --
> You received this message because you are subscribed to the Google Groups
> "google-breakpad-dev" group.
> To post to this group, send email to google-breakpad-dev@googlegroups.com.
> To unsubscribe from this group, send email to
> google-breakpad-dev+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/google-breakpad-dev?hl=en.
>
>


-- 
        Benjamin

[qsr]

It is my plan to have that working, especially because I just learned that
aggregation will only look at the first few frames and will be very wrong.

 It is not hard to do, but this is just some tiring code to write to
transform a u_context to the right format to pass to the minidump writer.

 Some of the work is already done on linux, I'll need to refactor this is
some common location.

On Fri, Mar 9, 2012 at 11:15 AM, Ted Mielczarek <ted@mielczarek.org> wrote:

> On Fri, Mar 9, 2012 at 1:09 PM,  <qsr@chromium.org> wrote:
> > PTAL as I disabled installing the handler for mac for now. Will try to
> > work on the context, but might not be just now.
>
> This would be cool to get working correctly on mac, since right now
> there's no way to externally trigger Breakpad (in a hung application,
> for example).
>
> -Ted
>
> --
> You received this message because you are subscribed to the Google Groups
> "google-breakpad-dev" group.
> To post to this group, send email to google-breakpad-dev@googlegroups.com.
> To unsubscribe from this group, send email to
> google-breakpad-dev+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/google-breakpad-dev?hl=en.
>
>