Change iOS implementation to not use exc_server

Change iOS implementation to not use exc_server

 Instead of using exc_server, the message is parsed directly, and the minidump
is created, then the app is killed.

 Moreover, the only catch exception is exception_raise. This patch remove all
 rereference to exception_raise_state and exception_raise_state_identity.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=934

[qsr]

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
File src/client/mac/handler/exception_handler.cc (right):

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:35: extern "C" {
Is that correct or should I remove the extern "C"? The only reason is it there
is that it defined function that were previously defined in this file with an
extern "C".

[Mark Mentovai]

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
File src/client/mac/handler/exception_handler.cc (right):

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:35: extern "C" {
qsr wrote:
> Is that correct or should I remove the extern "C"? The only reason is it there
> is that it defined function that were previously defined in this file with an
> extern "C".

extern "C" shouldn’t be necessary. If you look in <mach/exc.h>, you should see
that all function declarations are contained within a __BEGIN_DECLS/__END_DECLS
section. Looking in <sys/cdefs.h>, you’ll see that when compiling C++, these
macros create an |extern "C"| block.

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:158: // For the application to quit.
Now that I’ve examined some of my notes and bpoop work, I do think that you
should set some fields in the “out” message to avoid upsetting the kernel.

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:162: boolean_t
exc_server(mach_msg_header_t *request,
This already has a declaration on line 104, and that one is correct because it’s
in an |extern "C"| block.

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:407: fprintf(stderr, "** Unknown
exception behavior\n");
Print target_behavior too?

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:416: #else
Why not just #if !TARGET_OS_IPHONE?

[qsr]

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
File src/client/mac/handler/exception_handler.cc (right):

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:35: extern "C" {
On 2012/03/08 17:45:06, Mark Mentovai wrote:
> qsr wrote:
> > Is that correct or should I remove the extern "C"? The only reason is it
there
> > is that it defined function that were previously defined in this file with
an
> > extern "C".
> 
> extern "C" shouldn’t be necessary. If you look in <mach/exc.h>, you should see
> that all function declarations are contained within a
__BEGIN_DECLS/__END_DECLS
> section. Looking in <sys/cdefs.h>, you’ll see that when compiling C++, these
> macros create an |extern "C"| block.

Done.

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:158: // For the application to quit.
You are making a ugly code way uglier :)

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:162: boolean_t
exc_server(mach_msg_header_t *request,
On 2012/03/08 17:45:06, Mark Mentovai wrote:
> This already has a declaration on line 104, and that one is correct because
it’s
> in an |extern "C"| block.

Done.

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:407: fprintf(stderr, "** Unknown
exception behavior\n");
On 2012/03/08 17:45:06, Mark Mentovai wrote:
> Print target_behavior too?

Done.

http://breakpad.appspot.com/358001/diff/1001/src/client/mac/handler/exception...
src/client/mac/handler/exception_handler.cc:416: #else
You were not looking at the last version...

[Mark Mentovai]

LGTM