Issue 354001: Cast result of _dyld_image_count to prevent compilation warning.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 354001: Cast result of _dyld_image_count to prevent compilation warning. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by qsr

Modified:
12 years, 4 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

 Correct various compilation warnings.

 - Cast result of _dyld_image_count to prevent compilation warning: The 2 int
   in both side of the ? operator should have the same type.
 - Remove unused variable for return values.
 - Remove unused NSUserDefaults.

Patch Set 5 : '' #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/ios/Breakpad.mm	View	1 2 3 4	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/client/mac/handler/exception_handler.cc	View	1 2 3 4	3 chunks	+11 lines, -10 lines	0 comments	Download
M	src/client/mac/handler/minidump_generator.cc	View	1 2 3 4	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Mark Mentovai

https://breakpad.appspot.com/354001/diff/6001/src/client/mac/handler/minidump_generator.cc File src/client/mac/handler/minidump_generator.cc (right): https://breakpad.appspot.com/354001/diff/6001/src/client/mac/handler/minidump_generator.cc#newcode1322 src/client/mac/handler/minidump_generator.cc:1322: dynamic_images_->GetImageCount() : static_cast<int>(_dyld_image_count()); GetImageCount is internally just a cast ...

12 years, 4 months ago #3

qsr

12 years, 4 months ago #4

LGTM

Expand All Messages | Collapse All Messages