Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 353001: Modify CrashGenerator::CreateChildCrash to copy proc files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by Ben Chan
Modified:
12 years, 7 months ago
Reviewers:
Michael Krebs
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Modify CrashGenerator::CreateChildCrash to copy proc files.

This patch is taken from the downstream version of breakpad in
Chromium OS:  https://gerrit.chromium.org/gerrit/15148

LinuxCoreDumperTest previously assumes the proc files of the child
process created by CrashGenerator::CreateChildCrash() have the same
content as its parent process, which may not be true. This CL modifies
CrashGenerator to copy the proc files of the child process, created by
CreateChildCrash(), before crashing that process.

BUG=chromium-os:25252
TEST=Verified the following:
TEST=Tested the following:
1. Build on 32-bit and 64-bit Linux with gcc 4.4.3 and gcc 4.6.
2. Build on Mac OS X 10.6.8 with gcc 4.2 and clang 3.0 (with latest gmock).
3. All unit tests pass.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/linux_core_dumper_unittest.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M src/common/linux/tests/crash_generator.cc View 4 chunks +38 lines, -0 lines 0 comments Download
M src/common/linux/tests/crash_generator.h View 2 chunks +15 lines, -7 lines 0 comments Download
M src/common/tests/file_utils.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M src/common/tests/file_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Ben Chan
This patch is same as: https://gerrit.chromium.org/gerrit/15148
12 years, 7 months ago #1
Michael Krebs
12 years, 7 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted