Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 351001: Move away from the 10.4 SDK (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Mark Mentovai
Modified:
12 years, 8 months ago
Reviewers:
thakis
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Move away from the 10.4 SDK.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=922

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/Breakpad.xcodeproj/project.pbxproj View 1 chunk +0 lines, -3 lines 0 comments Download
M src/common/mac/Breakpad.xcconfig View 1 chunk +0 lines, -2 lines 1 comment Download

Messages

Total messages: 3
Mark Mentovai
Breakpad requires this since r915 anyway.
12 years, 8 months ago #1
thakis
lgtm https://breakpad.appspot.com/351001/diff/1/src/common/mac/Breakpad.xcconfig File src/common/mac/Breakpad.xcconfig (left): https://breakpad.appspot.com/351001/diff/1/src/common/mac/Breakpad.xcconfig#oldcode32 src/common/mac/Breakpad.xcconfig:32: SDKROOT[arch=i386] = macosx10.4 Yuck, I guess I'll need ...
12 years, 8 months ago #2
Mark Mentovai
12 years, 8 months ago #3
Yeah, this is all tied up with ARCHS and it’s a huge reason why you can’t just
invoke the compiler with multiple -arch arguments and let it figure things out.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted