Issue 350001: Handle bootstrap_register deprecation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 350001: Handle bootstrap_register deprecation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by Mark Mentovai

Modified:
12 years, 9 months ago

Reviewers:
thakis

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Funnel all bootstrap_register calls through a routine that doesn't care that
it's deprecated. Apple marked bootstrap_register as deprecated on 10.5 but
it's actually still needed on that OS release. There isn't a way to get the
functionality Breakpad needs from it without calling it until 10.6.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=921

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/mac/Breakpad.xcodeproj/project.pbxproj	View		9 chunks	+16 lines, -0 lines	0 comments	Download
M	src/client/mac/Framework/OnDemandServer.mm	View		3 chunks	+9 lines, -6 lines	0 comments	Download
M	src/client/mac/crash_generation/Inspector.mm	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/common/mac/MachIPC.mm	View		2 chunks	+5 lines, -3 lines	0 comments	Download
A	src/common/mac/bootstrap_compat.cc	View		1 chunk	+42 lines, -0 lines	0 comments	Download
A	src/common/mac/bootstrap_compat.h	View	1	1 chunk	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

thakis

12 years, 9 months ago #2

lgtm shrug

https://breakpad.appspot.com/350001/diff/1/src/common/mac/bootstrap_compat.cc
File src/common/mac/bootstrap_compat.cc (right):

https://breakpad.appspot.com/350001/diff/1/src/common/mac/bootstrap_compat.cc...
src/common/mac/bootstrap_compat.cc:38: return bootstrap_register(bp,
service_name, sp);
Maybe mention the 10.6 replacement here?

Expand All Messages | Collapse All Messages