Issue 346001: NXSwapBigIntToHost is deprecated, use CFSwapInt32BigToHost instead.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 346001: NXSwapBigIntToHost is deprecated, use CFSwapInt32BigToHost instead.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by thakis

Modified:
13 years, 2 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

NXSwapBigIntToHost is deprecated, use CFSwapInt32BigToHost instead.

Patch Set 1 #

Total comments: 1

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	client/mac/handler/breakpad_nlist_64.cc	View		5 chunks	+10 lines, -8 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

thakis

Adresses part of https://bugzilla.mozilla.org/show_bug.cgi?format=multiple&id=666646, too.

13 years, 2 months ago #1

Mark Mentovai

13 years, 2 months ago #2

LGTM otherwise. I checked in Breakpad r913 with this change.

https://breakpad.appspot.com/346001/diff/1/client/mac/handler/breakpad_nlist_...
File client/mac/handler/breakpad_nlist_64.cc (right):

https://breakpad.appspot.com/346001/diff/1/client/mac/handler/breakpad_nlist_...
client/mac/handler/breakpad_nlist_64.cc:70: #include
<CoreFoundation/CoreFoundation.h>
This counts as a C system header, it doesn’t go in a separate section separated
by a blank line from the headers below.

Expand All Messages | Collapse All Messages