Issue 290001: small fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 290001: small fix

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by albertzeyer

Modified:
12 years, 3 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/linux/dump_symbols.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ted Mielczarek

12 years, 3 months ago #3

http://breakpad.appspot.com/290001/diff/1/src/common/linux/dump_symbols.cc
File src/common/linux/dump_symbols.cc (right):

http://breakpad.appspot.com/290001/diff/1/src/common/linux/dump_symbols.cc#ne...
src/common/linux/dump_symbols.cc:134: ElfW(Word) base =
reinterpret_cast<ElfW(Word)>(obj_base);
I don't think this is correct. ElfW(Word) is only 32-bits for Elf64, you'd be
truncating the address in that case.

Expand All Messages | Collapse All Messages