Issue 288001: some fixes for MSVC / Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 288001: some fixes for MSVC / Windows

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by albertzeyer

Modified:
12 years, 3 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/google_breakpad/processor/minidump.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/google_breakpad/processor/minidump_processor.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/google_breakpad/processor/stackwalker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/google_breakpad/processor/symbol_supplier.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/processor/basic_source_line_resolver.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/processor/logging.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/processor/minidump.cc	View	2 chunks	+20 lines, -11 lines	0 comments	Download
M	src/processor/minidump_processor.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ted Mielczarek

12 years, 3 months ago #3

On 2011/05/22 23:03:42, albertzeyer wrote:
> Some missing includes, some missing functions, some warning-fixes.

Can you test the latest SVN? I fixed a few of these things a while ago to make
some of the processor code compile on MSVC.

Expand All Messages | Collapse All Messages