Issue 287001: some fixes for breakpad on windows. and some mingw crosscompiling fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 287001: some fixes for breakpad on windows. and some mingw crosscompiling fixes

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by albertzeyer

Modified:
12 years, 3 months ago

Reviewers:
Ted Mielczarek, Lei Zhang (chromium)

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/windows/common/ipc_protocol.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/client/windows/handler/exception_handler.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/common/windows/pdb_source_line_writer.cc	View	1 chunk	+2 lines, -0 lines	2 comments	Download
M	src/google_breakpad/common/breakpad_types.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

albertzeyer

In my mingw crosscompile version (on Linux), all header files were lower case. Because I ...

13 years ago #1

albertzeyer

In my mingw crosscompile version (on Linux), all header files were lower case. Because I ...

13 years ago #2

Ted Mielczarek

On 2011/05/22 23:03:20, albertzeyer wrote: > In my mingw crosscompile version (on Linux), all header ...

12 years, 3 months ago #3

Lei Zhang (chromium)

Agreed. This should be fine. http://breakpad.appspot.com/287001/diff/1/src/common/windows/pdb_source_line_writer.cc File src/common/windows/pdb_source_line_writer.cc (right): http://breakpad.appspot.com/287001/diff/1/src/common/windows/pdb_source_line_writer.cc#newcode31 src/common/windows/pdb_source_line_writer.cc:31: #include <Windows.h> wouldn't you ...

12 years, 3 months ago #4

albertzeyer

12 years, 3 months ago #5

http://breakpad.appspot.com/287001/diff/1/src/common/windows/pdb_source_line_...
File src/common/windows/pdb_source_line_writer.cc (right):

http://breakpad.appspot.com/287001/diff/1/src/common/windows/pdb_source_line_...
src/common/windows/pdb_source_line_writer.cc:31: #include <Windows.h>
On 2012/02/15 19:38:46, thestig wrote:
> wouldn't you want this to be lower case as well?
Yes. My changes regarding this were incomplete anyway because of many other
issues with MingW. But that was quite some time ago so I don't know about the
current state.

Expand All Messages | Collapse All Messages