Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(295)

Issue 1714002: Mac: Add support for in-process crash reporting to Breakpad. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by andresantoso
Modified:
10 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Mac: Add support for in-process crash reporting to Breakpad.

Add new option BREAKPAD_IN_PROCESS.
If YES, Breakpad will write the dump file in-process and then launch the
reporter
executable as a child  process.

Originally reviewed at https://codereview.chromium.org/571523004/

BUG=chromium:414239
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/apple/Framework/BreakpadDefines.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/client/mac/Framework/Breakpad.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/client/mac/Framework/Breakpad.mm View 6 chunks +58 lines, -0 lines 0 comments Download
M src/client/mac/crash_generation/ConfigFile.mm View 1 chunk +1 line, -1 line 0 comments Download
M src/client/mac/crash_generation/Inspector.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/client/mac/crash_generation/Inspector.mm View 3 chunks +4 lines, -47 lines 0 comments Download
A src/common/mac/launch_reporter.cc View 1 chunk +84 lines, -0 lines 0 comments Download
A src/common/mac/launch_reporter.h View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 6
andresantoso
Mark, PTAL. I have re-applied the patch to a SVN checkout.
10 years, 2 months ago #1
Mark Mentovai
LGTM. However: 1. Please leave a link to https://codereview.chromium.org/571523004/ in the commit message, so that ...
10 years, 2 months ago #2
Mark Mentovai
(You can use “gcl change xxxxx” to edit the description before committing.)
10 years, 2 months ago #3
andresantoso
On 2014/09/15 22:34:14, Mark Mentovai wrote: > LGTM. However: > > 1. Please leave a ...
10 years, 2 months ago #4
Mark Mentovai
LGTm
10 years, 2 months ago #5
andresantoso
10 years, 2 months ago #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r1375 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted