Issue 1694003: Cleanup: Remove Mac 10.5 macros.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1694003: Cleanup: Remove Mac 10.5 macros. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by Lei Zhang (chromium)

Modified:
11 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Cleanup: Remove Mac 10.5 macros.

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/mac/Framework/OnDemandServer.mm	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/client/mac/crash_generation/Inspector.mm	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	src/common/mac/GTMDefines.h	View	4 chunks	+6 lines, -60 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Mark Mentovai

LGTM. However, the code beneath src/client/mac is on the chopping block, so I wouldn’t consider ...

11 years, 1 month ago #2

Lei Zhang (chromium)

11 years, 1 month ago #3

On 2014/07/21 16:14:55, Mark Mentovai wrote:
> LGTM. However, the code beneath src/client/mac is on the chopping block, so I
> wouldn’t consider additional cleanup effort in that directory to be fruitful.

In that case, I'll just leave the code alone and close this CL.

Expand All Messages | Collapse All Messages