Issue 1654002: Add Arm64 support to dumpsyms.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1654002: Add Arm64 support to dumpsyms. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 12 months ago by rmcilroy

Modified:
9 years, 12 months ago

Reviewers:
Mark Mentovai, blundell

CC:
kerz_chromium.org

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Add Arm64 support to dumpsyms.

Adds Arm64 support to dumpsyms, enabling support for EM_AARCH64 elf type and
arm64 registers in DwarfCFIToModule.

BUG=367367,335641,354405
R=mark@chromium.org

Committed: 1322

Patch Set 1 #

Patch Set 2 : Add mac support in dump_syms.mm #

Patch Set 3 : Syn #

Patch Set 4 : Sync and rebase #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	common/dwarf_cfi_to_module.cc	View		2 chunks	+21 lines, -1 line	0 comments	Download
M	common/dwarf_cfi_to_module.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	common/linux/dump_symbols.cc	View	1 2	3 chunks	+9 lines, -0 lines	0 comments	Download
M	common/mac/dump_syms.mm	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rmcilroy

Mark, please take a look, thanks. blundell: do you want the RegisterNames::ARM64 support to be ...

9 years, 12 months ago #1

blundell

iOS doesn't use CFI, but ARM is included in the corresponding function in dump_syms.mm (DumpSymbols::ReadCFI), ...

9 years, 12 months ago #3

rmcilroy

On 2014/04/29 09:00:27, blundell wrote: > iOS doesn't use CFI, but ARM is included in ...

9 years, 12 months ago #4

Message was sent while issue was closed.

Committed patchset #4 manually as r1322 (presubmit successful).

Expand All Messages | Collapse All Messages