Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(204)

Issue 1504002: Renaming the 'build' directory as it collides with a file named 'BUILD' which is (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by ivanpe
Modified:
10 years, 7 months ago
Reviewers:
Mark Mentovai, chrisha
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Moving directory 'build' one level up as it collides with a file named 'BUILD'
which happens to be in that same location in the Google source depot.

R=chrisha@chromium.org, mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1308

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
D build/common.gypi View 1 chunk +0 lines, -1325 lines 0 comments Download
D build/external_code.gypi View 1 chunk +0 lines, -64 lines 0 comments Download
D build/internal/release_defaults.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
D build/internal/release_impl.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D build/internal/release_impl_official.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
D build/release.gypi View 1 chunk +0 lines, -18 lines 0 comments Download
A + src/build/common.gypi View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/build/external_code.gypi View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/build/internal/release_defaults.gypi View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/build/internal/release_impl.gypi View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/build/internal/release_impl_official.gypi View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/build/release.gypi View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/client/windows/breakpad_client.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/crash_generation/crash_generation.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/handler/exception_handler.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/sender/crash_report_sender.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/tests/crash_generation_app/crash_generation_app.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/unittests/client_tests.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/unittests/testing.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/common/windows/common_windows.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/tools/windows/dump_syms/dump_syms.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/tools/windows/symupload/symupload.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
ivanpe
10 years, 7 months ago #1
Mark Mentovai
LGTM, but get chrisha’s buy-in too. Either this or a renaming of build to something ...
10 years, 7 months ago #2
ivanpe
On 2014/04/10 01:31:29, Mark Mentovai wrote: > LGTM, but get chrisha’s buy-in too. Either this ...
10 years, 7 months ago #3
chrisha
Ah, didn't predict the Google3 fallout :) lgtm
10 years, 7 months ago #4
ivanpe
10 years, 7 months ago #5
Message was sent while issue was closed.
Committed patchset #2 manually as r1308 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted