Adding support for 64-bit Windows modules to ms_symbol_server_converter.

Adding support for 64-bit Windows modules to ms_symbol_server_converter.

As part of that:
 - Updated MSSymbolServerConverter to also download the executable files from
the symbol server and pass them to the PDBSourceLineWriter as it is required for
successful conversion of symbols for 64-bit modules.
 - Added a .gyp file and target for the ms_symbol_server_converter library.
 - Updated PDBSourceLineWriter to allow executable files to be in locations
different from the locations of the PDB files.
 - Minor style issue:
    * #define guards.
    * No space before ')' and after '('.

R=mark@chromium.org, wfh@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1309

[Mark Mentovai]

LGTM, but it would have been nice to do the cleanup in a separate change.

https://breakpad.appspot.com/1434002/diff/1/src/common/windows/pdb_source_lin...
File src/common/windows/pdb_source_line_writer.cc (right):

https://breakpad.appspot.com/1434002/diff/1/src/common/windows/pdb_source_lin...
src/common/windows/pdb_source_line_writer.cc:135: return (exe_file ==
code_file_);
No (parentheses).

https://breakpad.appspot.com/1434002/diff/1/src/tools/windows/converter/ms_sy...
File src/tools/windows/converter/ms_symbol_server_converter.cc (right):

https://breakpad.appspot.com/1434002/diff/1/src/tools/windows/converter/ms_sy...
src/tools/windows/converter/ms_symbol_server_converter.cc:119: const char
*kInvalidCharacters = "*;";
const char kInvalidCharacters[] = "*;";

https://breakpad.appspot.com/1434002/diff/1/src/tools/windows/converter/ms_sy...
src/tools/windows/converter/ms_symbol_server_converter.cc:220: const string
&version, string *file_name) {
string *file_name should go on its own line so it doesn’t get lost.

https://breakpad.appspot.com/1434002/diff/1/src/tools/windows/converter/ms_sy...
src/tools/windows/converter/ms_symbol_server_converter.cc:315: AutoDeleter
deleter(path);
Are you 100% sure that path will be terminated correctly? path[MAX_PATH - 1] =
'\0'; might be good cheap insurance here.

[ivanpe]

Sorry about mixing this with the style fixes.  I'll try to separate style fixes
in the future.

https://breakpad.appspot.com/1434002/diff/1/src/common/windows/pdb_source_lin...
File src/common/windows/pdb_source_line_writer.cc (right):

https://breakpad.appspot.com/1434002/diff/1/src/common/windows/pdb_source_lin...
src/common/windows/pdb_source_line_writer.cc:135: return (exe_file ==
code_file_);
On 2014/04/08 16:20:35, Mark Mentovai wrote:
> No (parentheses).

Done.

https://breakpad.appspot.com/1434002/diff/1/src/tools/windows/converter/ms_sy...
File src/tools/windows/converter/ms_symbol_server_converter.cc (right):

https://breakpad.appspot.com/1434002/diff/1/src/tools/windows/converter/ms_sy...
src/tools/windows/converter/ms_symbol_server_converter.cc:119: const char
*kInvalidCharacters = "*;";
On 2014/04/08 16:20:35, Mark Mentovai wrote:
> const char kInvalidCharacters[] = "*;";

Done.

https://breakpad.appspot.com/1434002/diff/1/src/tools/windows/converter/ms_sy...
src/tools/windows/converter/ms_symbol_server_converter.cc:220: const string
&version, string *file_name) {
On 2014/04/08 16:20:35, Mark Mentovai wrote:
> string *file_name should go on its own line so it doesn’t get lost.

Done.

https://breakpad.appspot.com/1434002/diff/1/src/tools/windows/converter/ms_sy...
src/tools/windows/converter/ms_symbol_server_converter.cc:315: AutoDeleter
deleter(path);
On 2014/04/08 16:20:35, Mark Mentovai wrote:
> Are you 100% sure that path will be terminated correctly? path[MAX_PATH - 1] =
> '\0'; might be good cheap insurance here.

Done.

[Will Harris]

LGTM - I didn't realise MS hosted binaries on their symbol server!

[Mark Mentovai]

LGTM

[ivanpe]

Committed patchset #2 manually as r1309 (presubmit successful).