Issue 1424002: Add Arm64 support to breakpad unittests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1424002: Add Arm64 support to breakpad unittests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rmcilroy

Modified:
10 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
primiano

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Add Arm64 support to breakpad unittests.

BUG=354405,335641
R=mark@chromium.org

Committed: 1305

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	client/linux/minidump_writer/linux_dumper_unittest_helper.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/linux/minidump_writer/minidump_writer_unittest.cc	View	2 chunks	+5 lines, -12 lines	0 comments	Download
M	common/android/include/sys/procfs.h	View	1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rmcilroy

https://breakpad.appspot.com/1424002/diff/1/common/android/include/sys/procfs.h File common/android/include/sys/procfs.h (right): https://breakpad.appspot.com/1424002/diff/1/common/android/include/sys/procfs.h#newcode39 common/android/include/sys/procfs.h:39: #include <asm/ptrace.h> Note: this is required for the struct ...

10 years, 7 months ago #1

Mark Mentovai

LGTM https://breakpad.appspot.com/1424002/diff/1/common/android/include/sys/procfs.h File common/android/include/sys/procfs.h (right): https://breakpad.appspot.com/1424002/diff/1/common/android/include/sys/procfs.h#newcode39 common/android/include/sys/procfs.h:39: #include <asm/ptrace.h> rmcilroy wrote: > Note: this is ...

10 years, 7 months ago #2

Message was sent while issue was closed.

Committed patchset #1 manually as r1305 (presubmit successful).

Expand All Messages | Collapse All Messages