Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 1404002: Fix ElfCoreDumpTest.ValidCoreFile unit test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by Ben Chan
Modified:
10 years, 7 months ago
Reviewers:
vapier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix ElfCoreDumpTest.ValidCoreFile unit test.

The ElfCoreDumpTest.ValidCoreFile unit test assumed that the number of
NT_FPREGSET / NT_PRXFPREG notes in the core dump file equals to the number of
threads of the crashed process. This assumption isn't always true as the kernel
skips filling the NT_FPREGSET / NT_PRXFPREG note of a thread if the FPU state
isn't available. The kernel indicates the availability of NT_FPREGSET /
NT_PRXFPREG via the pr_fpvalid field of the NT_PRSTATUS note. This CL modifies
the ElfCoreDumpTest.ValidCoreFile unit test to verify the number of NT_FPREGSET
and NT_PRXFPREG notes based on the pr_fpvalid field of the NT_PRSTATUS notes.

BUG=577
TEST=Run unit tests on x86 and x86_64 Linux platform.
R=vapier@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1303

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/linux/elf_core_dump_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Ben Chan
10 years, 7 months ago #1
Ben Chan
10 years, 7 months ago #2
vapier
lgtm i've verified it works on 2.6.32/3.6/3.9/3.11/3.14 versions 2.6.18/2.6.21 failed for an unrelated reason, but ...
10 years, 7 months ago #3
Ben Chan
10 years, 7 months ago #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1303 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted