Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(276)

Issue 1374002: Remove some unecessary Android system header definitions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by rmcilroy
Modified:
10 years ago
Reviewers:
Mark Mentovai
CC:
primiano
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src
Visibility:
Public.

Description

Remove some unecessary Android system header definitions.

Newer NDKs include some additional headers needed by Breakpad, so we can remove
these redefinitions.

BUG=358831,335641,354405
R=mark@chromium.org

Committed: 1300

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M common/android/include/link.h View 1 1 chunk +3 lines, -6 lines 0 comments Download
M common/android/include/sgidefs.h View 1 chunk +3 lines, -13 lines 0 comments Download
D common/android/include/sys/stat.h View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 7
rmcilroy
It turned out we can't remove as many files as I had hoped, but it ...
10 years ago #1
Mark Mentovai
LGTM https://breakpad.appspot.com/1374002/diff/1/common/android/include/link.h File common/android/include/link.h (right): https://breakpad.appspot.com/1374002/diff/1/common/android/include/link.h#newcode33 common/android/include/link.h:33: /* Android doesn't provide all the data-structures required ...
10 years ago #2
rmcilroy
Thanks. https://breakpad.appspot.com/1374002/diff/1/common/android/include/link.h File common/android/include/link.h (right): https://breakpad.appspot.com/1374002/diff/1/common/android/include/link.h#newcode33 common/android/include/link.h:33: /* Android doesn't provide all the data-structures required ...
10 years ago #3
rmcilroy
Mark: I've tried committing this but am getting authentication errors on when I try to ...
10 years ago #4
Mark Mentovai
Either: It’s an anonymous checkout now. You should “svn switch” it to an https checkout ...
10 years ago #5
rmcilroy
Committed patchset #2 manually as r1300 (presubmit successful).
10 years ago #6
rmcilroy
10 years ago #7
Message was sent while issue was closed.
On 2014/04/02 23:02:42, rmcilroy wrote:
> Committed patchset #2 manually as r1300 (presubmit successful).

That sorted it, thanks Mark.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted