Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 1334002: Terminating FileID path when at maximum length. (Coverity) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by Lei Zhang (chromium)
Modified:
10 years, 6 months ago
Reviewers:
cmumford
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Terminating FileID path when at maximum length. (Coverity)

If FileID was constructed with a path that was >= PATH_MAX then path_ was not
terminated resulting in a possible buffer overrun when reading.

BUG=573
A=cmumford@chromium.org
Original code review: https://breakpad.appspot.com/1324002/

R=cmumford@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/linux/file_id.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/common/linux/file_id.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
Lei Zhang (chromium)
10 years, 6 months ago #1
cmumford
On 2014/03/31 21:20:14, Lei Zhang (chromium) wrote: lgtm
10 years, 6 months ago #2
Lei Zhang (chromium)
10 years, 6 months ago #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1295 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted