Ignore warning 4702 to avoid unreachable code error on VS2013

Ignore warning 4702 to avoid unreachable code error on
VS2013 stl when compiling with _HAS_EXCEPTIONS=0

See also https://crbug.com/346399 for background.

BUG=540
R=mark@chromium.org, thestig@chromium.org
TEST=update gyp to HEAD, generate MSVS2013 build files, verify breakpad compiles
in Release.

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1292

[Will Harris]

This was the only thing required to move to VS2013 which is probably a good
thing to do since we've moved to VS2013 on Chromium now.

[Lei Zhang (chromium)]

In https://crbug.com/346399, we are trying to enable warning 4702, whereas here
you are disabling the warning. Isn't the proper solution to fix the offending
code in Breakpad?

[Lei Zhang (chromium)]

On 2014/03/25 19:56:39, Lei Zhang (chromium) wrote:
> In https://crbug.com/346399, we are trying to enable warning 4702, whereas
here
> you are disabling the warning. Isn't the proper solution to fix the offending
> code in Breakpad?

Ah, are you saying this is in MSVC's STL implementation and thus out of our
control?

[Will Harris]

On 2014/03/25 19:59:57, Lei Zhang (chromium) wrote:
> On 2014/03/25 19:56:39, Lei Zhang (chromium) wrote:
> > In https://crbug.com/346399, we are trying to enable warning 4702, whereas
> here
> > you are disabling the warning. Isn't the proper solution to fix the
offending
> > code in Breakpad?
> 
> Ah, are you saying this is in MSVC's STL implementation and thus out of our
> control?

Yes, the issue is in the MS STL. The MS connect link has all the details. MS
have it as WontFix because we are using an unsupported flag so this is our only
decent option for Vs2013, and it's what chromium already does.

[Mark Mentovai]

LGTM with a groan. It’s pretty unfortunate to disable this. If Chrome bug 346399
gets fixed and we can leverage that here, even if it means that we’re only able
to cleanly reenable this warning when building as part of Chrome, then we should
do that.

[Will Harris]

Thanks - as discussed on chat, we don't think this affects Chromium builds of
breakpad because the chromium builds use the Chromium gyp files and not the
breakpad gyp files, so I think any changes to Chromium build environment should
still take effect.

[Will Harris]

Committed patchset #1 manually as r1292 (presubmit successful).