Issue 1234002: Fix a bug in BreakpadController that prevented multiple report uploads per call to sendStoredCrashR…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1234002: Fix a bug in BreakpadController that prevented multiple report uploads per call to sendStoredCrashR… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by ivanpe.google

Modified:
10 years, 7 months ago

Reviewers:
Mark Mentovai, qsr, blundell, ashersb

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix a bug in BreakpadController that prevented multiple report uploads per call
to sendStoredCrashReports.

Submitting this patch on behalf of Asher Segel-Brown.

R=blundell@chromium.org, mark@chromium.org, qsr@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1288

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/ios/BreakpadController.mm	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

qsr

LGTM For blundell, see https://developer.apple.com/library/ios/documentation/cocoa/reference/foundation/classes/nsobject_class/reference/reference.html#//apple_ref/occ/instm/NSObject/performSelector:withObject:afterDelay: In short, performSelect afterDelay doesn't work correctly on queue, because ...

10 years, 7 months ago #3

Message was sent while issue was closed.

Committed patchset #1 manually as r1288 (presubmit successful).

Expand All Messages | Collapse All Messages