Issue 1204002: Trim unintentional whitespace and fix style nits

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1204002: Trim unintentional whitespace and fix style nits (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by mdempsky

Modified:
9 years, 9 months ago

Reviewers:
Lei Zhang (chromium), vapier

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master

Visibility:
Public.

More Reviews

Description

Trim unintentional whitespace and fix style nits

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	client/linux/handler/exception_handler.cc	View		3 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

mdempsky

On Mon, Mar 17, 2014 at 4:49 PM, <thestig@chromium.org> wrote: > lgtm > Thanks! Anything ...

10 years, 8 months ago #4

Lei Zhang (chromium)

On 2015/01/28 21:51:23, vapier wrote: > looks like this has been committed in r1387 ...

9 years, 10 months ago #6

mdempsky

9 years, 9 months ago #7

Message was sent while issue was closed.

On 2015/01/28 23:11:21, Lei Zhang (chromium) wrote:
> On 2015/01/28 21:51:23, vapier wrote:
> > looks like this has been committed in r1387 ... time to close ?
> 
> AFAICT, only the owner can close CLs on http://breakpad.appspot.com

Closed.

Expand All Messages | Collapse All Messages