Issue 1184003: Fixing compiler warnings:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1184003: Fixing compiler warnings: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Ivan Penkov

Modified:
10 years, 8 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com, ianh_google.com, gregvance_google.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixing compiler warnings:
 - Building Breakpad in Xcode with arm64 architecture.
 - iOS
Patches provided by: Ian Hickson and Greg Vance.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1286

Patch Set 3 : #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/ios/Breakpad.mm	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/client/mac/handler/minidump_generator.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/common/mac/file_id.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/common/mac/macho_id.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/common/memory.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

In the CL description, fix the spelling of “patches”. LGTM with this change. https://breakpad.appspot.com/1184003/diff/1/src/client/ios/Breakpad.mm File ...

10 years, 8 months ago #2

Ivan Penkov

Done. Committing shortly. https://breakpad.appspot.com/1184003/diff/1/src/client/ios/Breakpad.mm File src/client/ios/Breakpad.mm (right): https://breakpad.appspot.com/1184003/diff/1/src/client/ios/Breakpad.mm#newcode104 src/client/ios/Breakpad.mm:104: int rv = pthread_mutex_lock(mutex_); On 2014/02/28 ...

10 years, 8 months ago #3

Message was sent while issue was closed.

Committed patchset #3 manually as r1286 (presubmit successful).

Expand All Messages | Collapse All Messages