Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(114)

Issue 1174003: Adding a LICENSE file. COPYING is not needed anymore. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by Ivan Penkov
Modified:
10 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Renaming file COPYING to LICENSE and appending the disclaimer from
src/common/convert_UTF.h to LICENSE.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1285

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
D COPYING View 1 chunk +0 lines, -28 lines 0 comments Download
A + LICENSE View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M Makefile.am View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M Makefile.in View 1 2 3 4 3 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 9
Ivan Penkov
10 years, 9 months ago #1
Mark Mentovai
https://breakpad.appspot.com/1174003/diff/10003/COPYING File COPYING (left): https://breakpad.appspot.com/1174003/diff/10003/COPYING#oldcode1 COPYING:1: Copyright (c) 2006, Google Inc. automake will still try ...
10 years, 9 months ago #2
Ivan Penkov
On 2014/02/26 22:29:29, Mark Mentovai wrote: > https://breakpad.appspot.com/1174003/diff/10003/COPYING > File COPYING (left): > > https://breakpad.appspot.com/1174003/diff/10003/COPYING#oldcode1 ...
10 years, 9 months ago #3
Mark Mentovai
I don’t see any changes to configure.ac.
10 years, 9 months ago #4
Ivan Penkov
On 2014/02/26 22:38:31, Mark Mentovai wrote: > I don’t see any changes to configure.ac. Sorry, ...
10 years, 9 months ago #5
Mark Mentovai
As I said previously, you could add “foreign” to AM_INIT_AUTOMAKE in configure.ac. But adding it ...
10 years, 9 months ago #6
Ivan Penkov
https://breakpad.appspot.com/1174003/diff/10003/COPYING File COPYING (left): https://breakpad.appspot.com/1174003/diff/10003/COPYING#oldcode1 COPYING:1: Copyright (c) 2006, Google Inc. On 2014/02/26 22:29:29, Mark ...
10 years, 9 months ago #7
Mark Mentovai
LGTM
10 years, 9 months ago #8
Ivan Penkov
10 years, 9 months ago #9
Message was sent while issue was closed.
Committed patchset #5 manually as r1285 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted