Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(477)

Issue 1114002: make "make install" also install headers and pkgconfig files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by jturney
Modified:
5 years, 1 month ago
Reviewers:
vapier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

make "make install" also install headers and pkgconfig files

See https://code.google.com/p/google-breakpad/issues/detail?id=219

Patch Set 1 #

Total comments: 5

Patch Set 2 : make "make install" also install headers and pkgconfig files #

Total comments: 1

Patch Set 3 : make "make install" also install headers and pkgconfig files #

Total comments: 1

Patch Set 4 : make "make install" also install headers and pkgconfig files #

Patch Set 5 : make "make install" also install headers and pkgconfig files #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 2 2 chunks +32 lines, -0 lines 0 comments Download
A breakpad-client.pc.in View 1 3 1 chunk +10 lines, -0 lines 0 comments Download
A breakpad.pc.in View 1 3 1 chunk +10 lines, -0 lines 0 comments Download
M configure.ac View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13
vapier
5 years, 3 months ago #1
vapier
https://breakpad.appspot.com/1114002/diff/1/configure.ac File configure.ac (right): https://breakpad.appspot.com/1114002/diff/1/configure.ac#newcode94 configure.ac:94: AC_ARG_WITH(pkgconfigdir, i don't think we need a flag for ...
5 years, 3 months ago #2
vapier
https://breakpad.appspot.com/1114002/diff/1/Makefile.am File Makefile.am (right): https://breakpad.appspot.com/1114002/diff/1/Makefile.am#newcode80 Makefile.am:80: includeclhdir = $(prefix)/include/$(PACKAGE)/client/linux/handler this should be using $(includedir) instead ...
5 years, 3 months ago #3
jon.turney
Thanks for the review. I have amended the patch as requested. On 2014/07/30 17:28:56, vapier ...
5 years, 3 months ago #4
vapier
seems to me that libbreakpad_client.a includes at least elfutils.o and file_id.o and guid_creator.o and linux_libc_support.o ...
5 years, 3 months ago #5
jon.turney
On 2014/08/05 11:15:59, vapier wrote: > seems to me that libbreakpad_client.a includes at least elfutils.o ...
5 years, 3 months ago #6
vapier
ok, good point. the .pc file as is makes sense then.
5 years, 3 months ago #7
vapier
https://breakpad.appspot.com/1114002/diff/150001/breakpad-client.pc.in File breakpad-client.pc.in (right): https://breakpad.appspot.com/1114002/diff/150001/breakpad-client.pc.in#newcode4 breakpad-client.pc.in:4: includedir=@includedir@ i guess you want what you had before ...
5 years, 3 months ago #8
jon.turney
Please ignore patch set #4, it includes changes from autoreconf
5 years, 3 months ago #9
jon.turney
On 2014/08/07 04:48:07, vapier wrote: > https://breakpad.appspot.com/1114002/diff/150001/breakpad-client.pc.in > File breakpad-client.pc.in (right): > > https://breakpad.appspot.com/1114002/diff/150001/breakpad-client.pc.in#newcode4 > ...
5 years, 3 months ago #10
vapier
lgtm, but i want to see if anyone else has feedback before merging
5 years, 3 months ago #11
jon.turney
On 11/08/2014 02:23, vapier@chromium.org wrote: > lgtm, but i want to see if anyone else ...
5 years, 2 months ago #12
vapier
5 years, 2 months ago #13
i've gone ahead and committed it, but my gcl commit wasn't able to close this
... guess i need to get perms

Error accessing url /1114002/close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted