Fix some fragile code that is likely to cause future memory corruption problems.

Fix some fragile code that is likely to cause future memory corruption
problems.

- The ordering of keys in stl containers cannot change. Make the relevant 
members const to guarantee this assumption.
- Add handling and logging for demangle errors.
- Fix a potential double-delete bug if a function passed to AddFunction() is 
already present.

BUG=chromium:449214
R=mark@chromium.org

[erikchen]

mark: Please review.

I've tested compilation on Mac/Linux, and run tests via "make check" on Linux. I
think this CL will work fine on Windows, but I don't have a machine to confirm.
Is there standard procedure for running tests on all platforms?

[Mark Mentovai]

https://breakpad.appspot.com/10704002/diff/1/src/common/module.cc
File src/common/module.cc (right):

https://breakpad.appspot.com/10704002/diff/1/src/common/module.cc#newcode78
src/common/module.cc:78: void Module::AddFunction(Function *function) {
The CL description said you’d be fixing this, but you didn’t.

Are you saving that for a different change? That’s okay, just fix the CL
description.

Same for the DwarfCUToModule::WarningReporter::DemangleError portion.

https://breakpad.appspot.com/10704002/diff/1/src/common/module.h
File src/common/module.h (right):

https://breakpad.appspot.com/10704002/diff/1/src/common/module.h#newcode77
src/common/module.h:77: File(const string &name_input) : name(name_input) {}
explicit

https://breakpad.appspot.com/10704002/diff/1/src/common/module.h#newcode77
src/common/module.h:77: File(const string &name_input) : name(name_input) {}
Deterministically initialize the remaining fields?

https://breakpad.appspot.com/10704002/diff/1/src/common/module.h#newcode91
src/common/module.h:91: name(name_input), address(address_input) {}
Deterministically initialize the remaining fields?

https://breakpad.appspot.com/10704002/diff/1/src/common/module.h#newcode129
src/common/module.h:129: Extern(const Address &address_input) :
address(address_input) {}
explicit

[erikchen]

mark: PTAL

https://breakpad.appspot.com/10704002/diff/1/src/common/module.cc
File src/common/module.cc (right):

https://breakpad.appspot.com/10704002/diff/1/src/common/module.cc#newcode78
src/common/module.cc:78: void Module::AddFunction(Function *function) {
On 2015/01/27 00:11:57, Mark Mentovai wrote:
> The CL description said you’d be fixing this, but you didn’t.
> 
> Are you saving that for a different change? That’s okay, just fix the CL
> description.
> 
> Same for the DwarfCUToModule::WarningReporter::DemangleError portion.

I was shuttling patches between machines and managed to lose the changes. I've
updated the CL to include the changes.

https://breakpad.appspot.com/10704002/diff/1/src/common/module.h
File src/common/module.h (right):

https://breakpad.appspot.com/10704002/diff/1/src/common/module.h#newcode77
src/common/module.h:77: File(const string &name_input) : name(name_input) {}
On 2015/01/27 00:11:57, Mark Mentovai wrote:
> explicit

Done.

https://breakpad.appspot.com/10704002/diff/1/src/common/module.h#newcode77
src/common/module.h:77: File(const string &name_input) : name(name_input) {}
On 2015/01/27 00:11:57, Mark Mentovai wrote:
> Deterministically initialize the remaining fields?

Done.

https://breakpad.appspot.com/10704002/diff/1/src/common/module.h#newcode91
src/common/module.h:91: name(name_input), address(address_input) {}
On 2015/01/27 00:11:57, Mark Mentovai wrote:
> Deterministically initialize the remaining fields?

Done.

https://breakpad.appspot.com/10704002/diff/1/src/common/module.h#newcode129
src/common/module.h:129: Extern(const Address &address_input) :
address(address_input) {}
On 2015/01/27 00:11:57, Mark Mentovai wrote:
> explicit

Done.

[Mark Mentovai]

That’s better. LGTM.

[erikchen]

Manually submitted patch set 3 as
https://code.google.com/p/google-breakpad/source/detail?r=1415