Remove unecessary headers following NDK r10c update.

Remove unecessary headers following NDK r10c update.

BUG=chromium:358831

[fdegans]

PTAL
This will have to be rolled in with the NDK r10c update in Chromium to prevent
breakage.

[fdegans]

Also since there is no CQ, I should add someone who is a committer to actually
push the change but I don't know who. If one of you know who could do it, that'd
be great.

[primiano]

LGTM cause I like cleanups. However I'd like Ross to confirm as he might have
more context than me on this.
I can land the patch for you (did you check that "make check" is happy?)

Further question: When do you plan to roll this? The reason why I am asking is
because I have other stuff currently staging in breakpad (not rolled yet) and I
was planning to do a roll soon-ish. Any timeline here? Is this going to prevent
/ stall unrelated breakpad rolls? (If so we should wait to land this)

[fdegans]

This is not only cleanup, NDK r10c introduces breaking changes.
Chromium does not build with NDK r10c without this patch. And the other way
around, Chromium will not build with this patch applied and without NDK r10c so
the NDK and breakpad will both need to be rolled in Chromium at the same time.

I was planning on rolling the NDK this week as it would be nice to have the
Lollipop NDK in Chromium quickly and there are some toolchain improvements we
could use.

[rmcilroy]

On 2014/10/20 17:29:08, fdegans wrote:
> This is not only cleanup, NDK r10c introduces breaking changes.
> Chromium does not build with NDK r10c without this patch. And the other way
> around, Chromium will not build with this patch applied and without NDK r10c
so
> the NDK and breakpad will both need to be rolled in Chromium at the same time.
> 
> I was planning on rolling the NDK this week as it would be nice to have the
> Lollipop NDK in Chromium quickly and there are some toolchain improvements we
> could use.

Nice to get rid of some of these :). I think this should be fine. Did you check
it builds on Arm64 / x86_64?  If so, lgtm.

[primiano]

On 2014/10/20 17:53:19, rmcilroy wrote:
> On 2014/10/20 17:29:08, fdegans wrote:
> > This is not only cleanup, NDK r10c introduces breaking changes.
> > Chromium does not build with NDK r10c without this patch. And the other way
> > around, Chromium will not build with this patch applied and without NDK r10c
> so
> > the NDK and breakpad will both need to be rolled in Chromium at the same
time.
> > 
> > I was planning on rolling the NDK this week as it would be nice to have the
> > Lollipop NDK in Chromium quickly and there are some toolchain improvements
we
> > could use.
> 
> Nice to get rid of some of these :). I think this should be fine. Did you
check
> it builds on Arm64 / x86_64?  If so, lgtm.

Fabrice and I had a long offline discussion.
We can't just remove these files, as doing so breaks the compability with NDK <
r10c.
It is my understanding (looking at README.ANDROID in breakpad) that Chrome is
not the only Breakpad+Android client and I think we cannot just make breaking
changes like this.

Fabrice is going to send out a newer CL which is backwards compatible, where he
will conditionally (on  NDK > r10c) mask out / #include_next the system's
user.h, and keep compatibility with older NDKs.

For sake of records, this change was:
- landed in r1394
- reverted in r1395

Please mark this issue as closed.