Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 1064002: Support statically-linked libcurl for HTTP uploads in Linux

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by mattdr
Modified:
7 years, 6 months ago
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Support statically-linked libcurl for HTTP uploads in Linux.

Helpful at Google where we want to build freestanding binaries.

Patch Set 1 #

Patch Set 2 : previous patchset was invalid. #

Total comments: 2

Patch Set 3 : call dlclose(). check for NULL. #

Total comments: 2

Patch Set 4 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
src/common/linux/http_upload.cc View 1 2 3 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 8
mattdr
7 years, 6 months ago #1
Ivan Penkov
https://breakpad.appspot.com/1064002/diff/20001/src/common/linux/http_upload.cc File src/common/linux/http_upload.cc (right): https://breakpad.appspot.com/1064002/diff/20001/src/common/linux/http_upload.cc#newcode78 src/common/linux/http_upload.cc:78: curl_lib = NULL; Shouldn't we dlclose(curl_lib) before setting to ...
7 years, 6 months ago #2
Lei Zhang (chromium)
https://breakpad.appspot.com/1064002/diff/20001/src/common/linux/http_upload.cc File src/common/linux/http_upload.cc (right): https://breakpad.appspot.com/1064002/diff/20001/src/common/linux/http_upload.cc#newcode75 src/common/linux/http_upload.cc:75: void *curl_lib = dlopen(NULL, RTLD_NOW); void*, check for NULL ...
7 years, 6 months ago #3
mattdr
call dlclose(). check for NULL.
7 years, 6 months ago #4
Lei Zhang (chromium)
You need to change the description to include the "Support statically..." line. Otherwise the commit ...
7 years, 6 months ago #5
mattdr
Fix nit.
7 years, 6 months ago #6
mattdr
https://breakpad.appspot.com/1064002/diff/70001/src/common/linux/http_upload.cc File src/common/linux/http_upload.cc (right): https://breakpad.appspot.com/1064002/diff/70001/src/common/linux/http_upload.cc#newcode75 src/common/linux/http_upload.cc:75: void *curl_lib = dlopen(NULL, RTLD_NOW); On 2014/01/22 21:19:51, thestig ...
7 years, 6 months ago #7
Lei Zhang (chromium)
7 years, 6 months ago #8
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted