Support statically-linked libcurl for HTTP uploads in Linux

Support statically-linked libcurl for HTTP uploads in Linux.

Helpful at Google where we want to build freestanding binaries.

[Ivan Penkov]

https://breakpad.appspot.com/1064002/diff/20001/src/common/linux/http_upload.cc
File src/common/linux/http_upload.cc (right):

https://breakpad.appspot.com/1064002/diff/20001/src/common/linux/http_upload....
src/common/linux/http_upload.cc:78: curl_lib = NULL;
Shouldn't we dlclose(curl_lib) before setting to NULL?

[Lei Zhang (chromium)]

https://breakpad.appspot.com/1064002/diff/20001/src/common/linux/http_upload.cc
File src/common/linux/http_upload.cc (right):

https://breakpad.appspot.com/1064002/diff/20001/src/common/linux/http_upload....
src/common/linux/http_upload.cc:75: void *curl_lib = dlopen(NULL, RTLD_NOW);
void*, check for NULL return value.

[mattdr]

call dlclose(). check for NULL.

[Lei Zhang (chromium)]

You need to change the description to include the "Support statically..." line.
Otherwise the commit message will just say "Helpful at Google..."

https://breakpad.appspot.com/1064002/diff/70001/src/common/linux/http_upload.cc
File src/common/linux/http_upload.cc (right):

https://breakpad.appspot.com/1064002/diff/70001/src/common/linux/http_upload....
src/common/linux/http_upload.cc:75: void *curl_lib = dlopen(NULL, RTLD_NOW);
nit: "void *" -> "void* "

[mattdr]

Fix nit.

[mattdr]

https://breakpad.appspot.com/1064002/diff/70001/src/common/linux/http_upload.cc
File src/common/linux/http_upload.cc (right):

https://breakpad.appspot.com/1064002/diff/70001/src/common/linux/http_upload....
src/common/linux/http_upload.cc:75: void *curl_lib = dlopen(NULL, RTLD_NOW);
On 2014/01/22 21:19:51, thestig wrote:
> nit: "void *" -> "void* "

Done.

[Lei Zhang (chromium)]

lgtm