Submitting on bahalf of Michele Aiello.

Submitting on bahalf of Michele Aiello.

Fix Xcode 5.1 compilation issues.
Moving a couple of variable under #ifdef to avoid build warnings.

R=blundell@chromium.org, mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1272

[Mark Mentovai]

Not LGTM

https://breakpad.appspot.com/1054002/diff/1/src/client/ios/handler/ios_except...
File src/client/ios/handler/ios_exception_minidump_generator.mm (right):

https://breakpad.appspot.com/1054002/diff/1/src/client/ios/handler/ios_except...
src/client/ios/handler/ios_exception_minidump_generator.mm:97:
context_ptr->iregs[MD_CONTEXT_ARM_REG_IOS_FP] = kExpectedFinalFp;  // FP
These two?

https://breakpad.appspot.com/1054002/diff/1/src/client/ios/handler/ios_except...
src/client/ios/handler/ios_exception_minidump_generator.mm:115:
context_ptr->iregs[MD_CONTEXT_ARM64_REG_FP] = kExpectedFinalFp;      // FP
These two also?

https://breakpad.appspot.com/1054002/diff/1/src/client/ios/handler/ios_except...
src/client/ios/handler/ios_exception_minidump_generator.mm:188: assert(sp ==
kExpectedFinalSp);
And these two?

[blundell]

https://breakpad.appspot.com/1054002/diff/1/src/client/ios/handler/ios_except...
File src/client/ios/handler/ios_exception_minidump_generator.mm (left):

https://breakpad.appspot.com/1054002/diff/1/src/client/ios/handler/ios_except...
src/client/ios/handler/ios_exception_minidump_generator.mm:46: const uintptr_t
kExpectedFinalFp = sizeof(uintptr_t);
I think that just need to be moved into the block that sstarts on line 51:
they're used when building for ARM (i.e., for devices) but not when building for
x86 (i.e., for the simulator). I don't know offhand if the two below these two
are in the same situation.

[Ivan Penkov]

Sorry, I should have done a more careful code review before forwarding this
patch.  Thanks for catching this.  PTAL.

[blundell]

LGTM

Please update the CL description.

[Mark Mentovai]

LGTM.

[Ivan Penkov]

Committed patchset #2 manually as r1272 (presubmit successful).