Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 441 - 460 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
375001	Stackwalker Fix for AMD64 (Closed)	mrmiller	jimb, Ted Mielczarek	4	14 years
382001	Make Breakpad build with DSO linking on newer versions of Fedora/Ubuntu. (Closed)	Lei Zhang (chromium)	Mark Mentovai		14 years
376001	Fix file descriptor leak in GetThreadInfoByIndex (Closed)	chrisdearman	Ben Chan		14 years
377004	Set limit on the number of custom client info entries that can be sent with a crash dump. (Closed)	Cris Neckar	cpu		14 years
345001	Fix test addresses to use uintptr_t instead of u_int64_t. (Closed)	Michael Krebs	Ben Chan, Lei Zhang (chromium), Ted Mielczarek		14 years
379001	Expose a callback to allow crash server implementations to defer the uploading of crash dumps to a … (Closed)	Cris Neckar	cpu1, cpu		14 years
372002	Fix file descriptor leaks in ExternalDumper test (Closed)	chrisdearman	mochalatte, Ted Mielczarek		14 years
374001	Fix crash_generator error message (Closed)	chris	Ted Mielczarek		14 years
380001	vectors are cleared with "clear()", not with "empty() (Closed)	Lei Zhang (chromium)	thakis		14 years
371002	Fixed "unused method" warning, reported by Xcode 4.2 on simulator. (Closed)	qsr	Mark Mentovai		14 years, 1 month
369001	Fix several issues in linux_dumper_unittest_helper (Closed)	chris	Ted Mielczarek	1	14 years, 1 month
372001	Remove redundant include of CPP specific header files (Closed)	chris	Ted Mielczarek		14 years, 1 month
373001	Add missing log.o dependency to linux_client_unittest target. (Closed)	Ben Chan	Mark Mentovai, carlosvaldivia		14 years, 1 month
366002	Fix for putting main module as first one in minidump (Closed)	Michael Krebs	Mark Mentovai, Ben Chan		14 years, 1 month
366001	Fix GetMainModule() to properly get first module (Closed)	Michael Krebs	Mark Mentovai, Ben Chan		14 years, 1 month
371001	Fix memory leak in DisassemblerX86. (Closed)	Ben Chan	Mark Mentovai, Lei Zhang (chromium)		14 years, 1 month
368001	Fix class/struct mismatches in forward declarations. (Closed)	Ben Chan	Mark Mentovai, Lei Zhang (chromium)		14 years, 1 month
365001	Unregister waits when a client shuts down so that no further callback events can fire for that clie… (Closed)	Cris Neckar	munjal, cpu1, doshimun		14 years, 1 month
361001	Add high level API for breakpad on iOS. (Closed)	qsr	Mark Mentovai	69	14 years, 1 month
358001	Change iOS implementation to not use exc_server (Closed)	qsr	Mark Mentovai	11	14 years, 1 month

« Newest ‹ Newer 441 - 460 Older ›