Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 421 - 440 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
407002	Add Android NDK module definition + sample application (Closed)	digit	Mark Mentovai, Ted Mielczarek	68	13 years, 9 months
410002	Allow the minidump writer to collect handle data so that resulting dump contains information about … (Closed)	alexeypa	Mark Mentovai, Ted Mielczarek, justin	9	13 years, 9 months
412002	Fix compilation directive for PPC. (Closed)	qsr	Mark Mentovai		13 years, 9 months
409003	Do not fail crash dump generation if handle operations tracing is not enabled and yet the fatal exc… (Closed)	alexeypa	Mark Mentovai		13 years, 10 months
396002	CrashGenerationServer's state machine in can be invoked from both the application thread and thread… (Closed)	alexeypa	Mark Mentovai	7	13 years, 10 months
399002	The end goal of this change is to boost the test coverage of breakpad in Google (Closed)	ivanpe.google	Mark Mentovai, Ted Mielczarek	41	13 years, 10 months
395002	Fixing a mem leak which affects 3 unittests (Closed)	ivanpe.google	Mark Mentovai, Ted Mielczarek	7	13 years, 10 months
394002	Breakpad fails to walk stacks which have FPO-optimized Windows system calls in the context frame (Closed)	ivanpe.google	Mark Mentovai, Ted Mielczarek	49	13 years, 10 months
401002	Fix Android build of the client library. (Closed)	digit	Mark Mentovai, Ted Mielczarek	10	13 years, 10 months
398002	Fix a race condition in AutoCriticalSection. (Closed)	Lei Zhang (chromium)	alexeypa, Mark Mentovai		13 years, 10 months
391002	Fix uploader so that it send the guid to the server. (Closed)	qsr	Mark Mentovai		13 years, 11 months
388002	sym_upload: Show failure if symbol server gives redirect response (Closed)	Michael Krebs	Ted Mielczarek		13 years, 11 months
390003	Initialize a CustomClientInfo variable. (Coverity) (Closed)	Lei Zhang (chromium)	Cris Neckar, cpu1		13 years, 11 months
390002	Fixing HTTPMultipartUpload. (Closed)	qsr	Mark Mentovai		13 years, 11 months
389002	Unprotect the allocator before trying to create a minidump from a signal. (Closed)	qsr	stuart.morgan	2	13 years, 11 months
386002	Fix warning C4800 (Closed)	Jess	Cris Neckar, cpu, Ted Mielczarek		13 years, 12 months
384001	wires up the crash client side so that the deferred upload callback can be used. (Closed)	Cris Neckar	cpu	1	14 years
377002	Fix race in VerifyStackReadWithMultipleThreads (Closed)	chrisdearman	Ted Mielczarek	4	14 years
377001	Fix compilation warnings related to unchecked return values (Closed)	chrisdearman	mochalatte, Ben Chan, Ted Mielczarek	3	14 years
378001	Reap child in VerifyStackReadWithMultipleThreads (Closed)	chrisdearman	Ben Chan	1	14 years

« Newest ‹ Newer 421 - 440 Older ›