Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 6704002: In Mac dump_syms, allow reading debug data out of both the Mach-O file and the dSYM. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by rsesek
Modified:
9 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

In Mac dump_syms, allow reading debug data out of both the Mach-O file and the
dSYM.

This adds a new |-g <dSYM path>| flag to dump_syms, to specify the dSYM path for
the target Mach-O argument. The UUIDs and architectures of the two paths must
match in order to dump symbols for this "split module."

This reason for this is that for x86_64 binaries on OS X, the CFI data is stored
in the __TEXT,__eh_frame segment of the Mach-O file, and the data is not copied
into the dSYM by dsymutil.  Therefore, just dumping the dSYM doesn't yield CFI
data for x86_64 files, and both the dSYM and the Mach-O file must be dumped in
order to produce a complete Breakpad symbol file. For i386 binaries, the CFI
data
is stored in the __DWARF,__debug_frame segment, which is part of the dSYM, so
this isn't necessary.

BUG=https://code.google.com/p/chromium/issues/detail?id=393594
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1359

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/module.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/common/module.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/tools/mac/dump_syms/dump_syms_tool.mm View 1 4 chunks +103 lines, -9 lines 0 comments Download

Messages

Total messages: 4
rsesek
9 years, 9 months ago #1
Mark Mentovai
LGTM https://breakpad.appspot.com/6704002/diff/1/src/tools/mac/dump_syms/dump_syms_tool.mm File src/tools/mac/dump_syms/dump_syms_tool.mm (right): https://breakpad.appspot.com/6704002/diff/1/src/tools/mac/dump_syms/dump_syms_tool.mm#newcode60 src/tools/mac/dump_syms/dump_syms_tool.mm:60: static bool StackFrameEntryComparitor(const Module::StackFrameEntry* a, Comparator, “a”, not ...
9 years, 9 months ago #2
rsesek
https://breakpad.appspot.com/6704002/diff/1/src/tools/mac/dump_syms/dump_syms_tool.mm File src/tools/mac/dump_syms/dump_syms_tool.mm (right): https://breakpad.appspot.com/6704002/diff/1/src/tools/mac/dump_syms/dump_syms_tool.mm#newcode60 src/tools/mac/dump_syms/dump_syms_tool.mm:60: static bool StackFrameEntryComparitor(const Module::StackFrameEntry* a, On 2014/07/25 18:06:19, Mark ...
9 years, 9 months ago #3
rsesek
9 years, 9 months ago #4
Message was sent while issue was closed.
Committed patchset #2 manually as r1359 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted