Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Unified Diff: src/google_breakpad/processor/stack_frame.h

Issue 621002: Create StackFrame::FRAME_TRUST_PREWALKED trust type. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: Addressed Ted's comments. Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/processor/stackwalker_address_list.cc » ('j') | src/processor/stackwalker_address_list.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/google_breakpad/processor/stack_frame.h
===================================================================
--- src/google_breakpad/processor/stack_frame.h (revision 1207)
+++ src/google_breakpad/processor/stack_frame.h (working copy)
@@ -45,12 +45,13 @@
// stack scanning, it can wind up with dubious frames.
// In rough order of "trust metric".
enum FrameTrust {
- FRAME_TRUST_NONE, // Unknown
- FRAME_TRUST_SCAN, // Scanned the stack, found this
- FRAME_TRUST_CFI_SCAN, // Scanned the stack using call frame info, found this
- FRAME_TRUST_FP, // Derived from frame pointer
- FRAME_TRUST_CFI, // Derived from call frame info
- FRAME_TRUST_CONTEXT // Given as instruction pointer in a context
+ FRAME_TRUST_NONE, // Unknown
+ FRAME_TRUST_SCAN, // Scanned the stack, found this
+ FRAME_TRUST_CFI_SCAN, // Found while scanning stack using call frame info
+ FRAME_TRUST_FP, // Derived from frame pointer
+ FRAME_TRUST_CFI, // Derived from call frame info
+ FRAME_TRUST_PREWALKED, // Explicitly provided by some external stack walker.
+ FRAME_TRUST_CONTEXT // Given as instruction pointer in a context
};
StackFrame()
@@ -70,6 +71,8 @@
switch (trust) {
case StackFrame::FRAME_TRUST_CONTEXT:
return "given as instruction pointer in context";
+ case StackFrame::FRAME_TRUST_PREWALKED:
+ return "recovered by external stack walker";
case StackFrame::FRAME_TRUST_CFI:
return "call frame info";
case StackFrame::FRAME_TRUST_CFI_SCAN:
« no previous file with comments | « no previous file | src/processor/stackwalker_address_list.cc » ('j') | src/processor/stackwalker_address_list.cc » ('J')

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted