src/client/linux/minidump_writer/linux_core_dumper.cc - Issue 614002: [MIPS] Add support for Breakpad for MIPS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: src/client/linux/minidump_writer/linux_core_dumper.cc

Issue 614002: [MIPS] Add support for Breakpad for MIPS (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/src/

Patch Set: Added unittest for stackwalker_mips class and few more changes as per code review comments. Created 11 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/client/linux/minidump_writer/linux_core_dumper.cc

===================================================================

--- src/client/linux/minidump_writer/linux_core_dumper.cc (revision 1208)

+++ src/client/linux/minidump_writer/linux_core_dumper.cc (working copy)

@@ -99,6 +99,9 @@

memcpy(&stack_pointer, &info->regs.rsp, sizeof(info->regs.rsp));

#elif defined(__ARM_EABI__)

memcpy(&stack_pointer, &info->regs.ARM_sp, sizeof(info->regs.ARM_sp));

+#elif defined(__mips__)

+ stack_pointer =

+ reinterpret_cast<uint8_t*>(info->regs.regs[MD_CONTEXT_MIPS_REG_SP]);

#else

#error "This code hasn't been ported to your platform yet."

#endif