src/processor/stackwalker_unittest_utils.h - Issue 5684002: Refactoring in preparation for microdump processing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/processor/stackwalker_unittest_utils.h

Issue 5684002: Refactoring in preparation for microdump processing (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/

Left Patch Set: Argh, revert aclocal.m4 again; and add some blank line around namespaces. Created 10 years, 7 months ago

Right Patch Set: More alpha sorting fixes in Makefile.am Created 10 years, 7 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 // -- mode: C++ --	1 // -- mode: C++ --

2	2

3 // Copyright (c) 2010, Google Inc.	3 // Copyright (c) 2010, Google Inc.

4 // All rights reserved.	4 // All rights reserved.

5 //	5 //

6 // Redistribution and use in source and binary forms, with or without	6 // Redistribution and use in source and binary forms, with or without

7 // modification, are permitted provided that the following conditions are	7 // modification, are permitted provided that the following conditions are

8 // met:	8 // met:

9 //	9 //

10 // * Redistributions of source code must retain the above copyright	10 // * Redistributions of source code must retain the above copyright

(...skipping 191 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
202 }	202 }

203 }	203 }

204	204

205 private:	205 private:

206 // List of symbol data to be freed upon destruction	206 // List of symbol data to be freed upon destruction

207 typedef std::vector<char*> SymbolDataVector;	207 typedef std::vector<char*> SymbolDataVector;

208 SymbolDataVector symbol_data_to_free_;	208 SymbolDataVector symbol_data_to_free_;

209 };	209 };

210	210

211 #endif // PROCESSOR_STACKWALKER_UNITTEST_UTILS_H_	211 #endif // PROCESSOR_STACKWALKER_UNITTEST_UTILS_H_

LEFT	RIGHT