Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(364)

Issue 554003: Fix missing result check in Mac exception handler

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by georg.fritzsche
Modified:
11 years, 7 months ago
Reviewers:
Ted Mielczarek
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The Mac exception handler is missing a result check for notifying the handler
thread, which may result in deadlock.

Context:
https://bugzilla.mozilla.org/show_bug.cgi?id=836829#c3

Already mistakenly filed:
http://code.google.com/p/google-breakpad/issues/detail?id=525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
src/client/mac/handler/exception_handler.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 2
georg.fritzsche
11 years, 7 months ago #1
Ted Mielczarek
11 years, 7 months ago #2

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted