Issue 551002: Turn off verbose logging but keep logic for future reference for debug logging.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 551002: Turn off verbose logging but keep logic for future reference for debug logging. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by Jess

Modified:
12 years, 4 months ago

Reviewers:
Ivan Penkov, Mark Mentovai, Ted Mielczarek, Lei Zhang (chromium)

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Making comment consistent before mailing. #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	processor/range_map-inl.h	View	1	2 chunks	+23 lines, -13 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Ted Mielczarek

On 2013/04/04 23:55:49, Jess wrote: Yes, yes, a thousand times yes! (That is to say, ...

12 years, 4 months ago #2

Lei Zhang (chromium)

On 2013/04/05 00:19:31, Ted Mielczarek wrote: > On 2013/04/04 23:55:49, Jess wrote: > > Yes, ...

12 years, 4 months ago #3

Mark Mentovai

thestig wrote: > On 2013/04/05 00:19:31, Ted Mielczarek wrote: > > On 2013/04/04 23:55:49, Jess ...

12 years, 4 months ago #4

Message was sent while issue was closed.

On 2013/04/05 18:23:33, Jess wrote:
> No.  We know this is an open issue and I'd love to keep these around as
> VLOG errors for later investigation.
> 
> However we do not see processing errors associated with these and they make
> it difficult to investigate more critical issues because they are so
> verbose.
> 
> 
> On Fri, Apr 5, 2013 at 9:19 AM, <mailto:mark@chromium.org> wrote:
> 
> > thestig wrote:
> >
> >> On 2013/04/05 00:19:31, Ted Mielczarek wrote:
> >> > On 2013/04/04 23:55:49, Jess wrote:
> >> >
> >> > Yes, yes, a thousand times yes! (That is to say, LGTM.)
> >>
> >
> >  Has anyone looked at the actual cause of all these warning?
> >>
> >
> > That’s my question too.
> >
> >
https://breakpad.appspot.com/**551002/%3Chttps://breakpad.appspot.com/551002/>
> >

We have a bug tracking the investigation of these warnings but we haven't done
that investigation yet.  I agree that the verbosity of these warnings is a
problem and that it makes it difficult to investigate other issues.

Expand All Messages | Collapse All Messages